Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-1550) add new Feature MySQL login paths #1295

Merged
merged 24 commits into from
May 27, 2020
Merged

(MODULES-1550) add new Feature MySQL login paths #1295

merged 24 commits into from
May 27, 2020

Conversation

andreas-stuerz
Copy link
Contributor

@sheenaajay
Copy link
Contributor

Thanks @andeman for submitting the PR. Thanks for the detailed information on the ticket too. Good Work.

REFERENCE.md Outdated
* `mysql::server::config`: Private class for MySQL server configuration.
* `mysql::server::install`: Private class for managing MySQL package.
* `mysql::server::installdb`: Builds initial databases on installation.
* `mysql::server::managed_dirs`: Binary log configuration requires the mysql user to be present. This must be done after package install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `mysql::server::managed_dirs`: Binary log configuration requires the mysql user to be present. This must be done after package install
* `mysql::server::managed_dirs`: Binary log configuration requires the mysql user to be present. This must be done after package install.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -0,0 +1,9 @@
#!/bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the scripts since all the test setup will be specified in the travis.yml file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -0,0 +1,2 @@
#!/bin/sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the scripts folder since we have test setups and tear down specified in travis.yml file.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -0,0 +1,92 @@
# frozen_string_literal: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding unit tests and acceptance tests. Will run them against release checks to verify on other OSes too. Thank you

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

Andreas Stuerz and others added 19 commits April 22, 2020 09:26
pdksync - Add dependency gems to development group
There's been a properly namespaced modern `mysql::password` function for
some time.  See #1044

When the modern API non-namespaced shim was removed in a68004c
the `puppet/parser/functions` version still existed so users who hadn't
migrated to `mysql::password` would have reverted to this legacy API version.

This commit finally removes the legacy version, but puts back the shim
for now (to not create a breaking change just yet).

Both namespaced and non-namespaced shim are tested.
…d_function

Remove legacy (old API) `mysql_password` function
* fix xtrabackup target directory and related regressions

* fix handling of incremental backups with xtrabackup

* MODULES-10023 add parameter $incremental_backups to parent class

* MODULES-10023 add acceptance tests for xtrabackup

* MODULES-10023 add xtrabackup documentation

* MODULES-10023 fix acceptance tests

* MODULES-10023 fix xtrabackup tests on CentOS 6

* MODULES-10023 fix xtrabackup tests on Debian 8, Ubuntu 14.04, Scientific 6

* MODULES-10023 fix xtrabackup tests on SLES, RHEL 8 and RHEL/CentOS 5

* MODULES-10023 fix xtrabackup tests on RHEL/CentOS 5

* MODULES-10023 disable new xtrabackup tests on EOL operating systems

* (maint) exclude oracle6/centos6 platforms on running the feature tests

Co-authored-by: David Swan <david.swan@puppet.co.uk>
Co-authored-by: sheena <sheena@puppet.com>
Co-authored-by: Auto-release <team-modules@puppet.com>
This makes it easier for other modules also trying to manage the 'cron'
package not to conflict.
pdksync - Use abs instead of vmpooler to provision test resources
Use ensure_packages() to install  the cron packages
@sheenaajay
Copy link
Contributor

@andeman Could you please rebase with latest master. I am rerunning them on all OSes. Thank you.

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@fff2c82). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1295   +/-   ##
=========================================
  Coverage          ?   50.23%           
=========================================
  Files             ?       22           
  Lines             ?     1045           
  Branches          ?        0           
=========================================
  Hits              ?      525           
  Misses            ?      520           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fff2c82...0bbe3fe. Read the comment docs.

@sheenaajay
Copy link
Contributor

Screenshot 2020-05-27 at 10 24 47

@sheenaajay
Copy link
Contributor

Thanks alot for your contribution @andeman Great Work.

@sheenaajay sheenaajay merged commit 23f89af into puppetlabs:master May 27, 2020
@djholms
Copy link

djholms commented Jun 4, 2020

Hello @andeman and Team,
I faced with issue using this feature.

$root_pw = 'password'
mysql_login_path { 'client':
  password => Sensitive($root_pw), 
}

I got following error (only with this module):

Error: Transaction store file /opt/puppetlabs/puppet/cache/state/transactionstore.yaml is corrupt ((/opt/puppetlabs/puppet/cache/state/transactionstore.yaml): Tried to load unspecified class: Puppet::Provider::MysqlLoginPath::Sensitive); replacing
Wrapped exception:
Tried to load unspecified class: Puppet::Provider::MysqlLoginPath::Sensitive

Before using this feature I didn't face this error.
Thanks for Your support

Style/BracesAroundHashParameters:
Description: Braces are required by Ruby 2.7. Cop removed from RuboCop v0.80.0.
See https://github.com/rubocop-hq/rubocop/pull/7643
Enabled: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?? Seems to directly contradict the change made in PDK.
puppetlabs/pdk-templates#329

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore this comment. It doesn't relate to this PR. Rebasing/merging must have gone a bit funny at some point to pull this in here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants