handling of my.cnf config file is now optional #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if $manage_config_file and $config_file =~ /^\/etc\/mysql\// { | ||
| File['/etc/mysql'] -> File[$config_file] | ||
| } |
There was a problem hiding this comment.
These should not be needed due to implicit dependencies.
There was a problem hiding this comment.
good point.. I changed it..
|
Hi, Would it be possible to rebase this change against an updated copy of master? In addition we'd need some rspec-puppet tests before we could merge this in. There's a bunch of pre-existing tests in spec/classes/mysql_config_spec.rb that you can crib from to put together two tests, one for each boolean. Let me know if you run into any problems with specs or simply don't have the time to take this on (or simply don't care about this feature anymore!). |
This adds a parameter (default value is like old behavior) so that the my.cnf file isn't managed (created/updated) by the mysql module at all which is necessary for our environment. We need to set all parameters by ourself. If we don't set a parameter then the default from the mysqld binary should be used instead of any default parameter the mysql module provides us.
|
I tried to sync with master. I hope it is acceptable. |
apenney
added a commit
that referenced
this pull request
Jul 2, 2013
handling of my.cnf config file is now optional
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
Run pdk update to obtain .travis.yml template update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a parameter (default value is like old behavior) so that the
my.cnf file isn't managed (created/updated) by the mysql module at all
which is necessary for our environment. We need to set all parameters by
ourself. If we don't set a parameter then the default from the mysqld
binary should be used instead of any default parameter the mysql module
provides us.