Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

handling of my.cnf config file is now optional #132

Merged
merged 1 commit into from Jul 2, 2013

Conversation

Projects
None yet
3 participants
Contributor

Savar commented Dec 8, 2012

This adds a parameter (default value is like old behavior) so that the
my.cnf file isn't managed (created/updated) by the mysql module at all
which is necessary for our environment. We need to set all parameters by
ourself. If we don't set a parameter then the default from the mysqld
binary should be used instead of any default parameter the mysql module
provides us.

@hunner hunner and 1 other commented on an outdated diff Jan 4, 2013

manifests/config.pp
}
+ File['/etc/mysql'] -> File['/etc/mysql/conf.d']
+
+ if $manage_config_file and $config_file =~ /^\/etc\/mysql\// {
+ File['/etc/mysql'] -> File[$config_file]
+ }
@hunner

hunner Jan 4, 2013

Member

These should not be needed due to implicit dependencies.

@Savar

Savar Jan 9, 2013

Contributor

good point.. I changed it..

Contributor

apenney commented Jul 2, 2013

Hi,

Would it be possible to rebase this change against an updated copy of master? In addition we'd need some rspec-puppet tests before we could merge this in. There's a bunch of pre-existing tests in spec/classes/mysql_config_spec.rb that you can crib from to put together two tests, one for each boolean.

Let me know if you run into any problems with specs or simply don't have the time to take this on (or simply don't care about this feature anymore!).

handling of my.cnf config file is now optional
This adds a parameter (default value is like old behavior) so that the
my.cnf file isn't managed (created/updated) by the mysql module at all
which is necessary for our environment. We need to set all parameters by
ourself. If we don't set a parameter then the default from the mysqld
binary should be used instead of any default parameter the mysql module
provides us.
Contributor

Savar commented Jul 2, 2013

I tried to sync with master. I hope it is acceptable.

apenney added a commit that referenced this pull request Jul 2, 2013

Merge pull request #132 from Savar/manage_config_file_parameter
handling of my.cnf config file is now optional

@apenney apenney merged commit 9839a1c into puppetlabs:master Jul 2, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment