Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CONT-576) allow deferred function for token & secrets #1569

Merged
merged 1 commit into from May 23, 2023
Merged

Conversation

Ramesh7
Copy link
Contributor

@Ramesh7 Ramesh7 commented May 19, 2023

  • implementing deferred function for password field

@Ramesh7 Ramesh7 requested a review from a team as a code owner May 19, 2023 11:59
@puppet-community-rangefinder
Copy link

mysql::backup::mysqlbackup is a class

that may have no external impact to Forge modules.

mysql::backup::mysqldump is a class

that may have no external impact to Forge modules.

mysql::backup::xtrabackup is a class

that may have no external impact to Forge modules.

mysql::db is a type

Breaking changes to this file WILL impact these 68 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

mysql::server::root_password is a class

that may have no external impact to Forge modules.

This module is declared in 140 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@@ -1,6 +1,7 @@
# frozen_string_literal: true

require 'spec_helper'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Observed failure on my local with uninitialized

  2) Puppet::Provider::MysqlLoginPath::MysqlLoginPath create(context, name, should) creates the resource
     Failure/Error: let(:context) { instance_double(Puppet::ResourceApi::BaseContext) }

     NameError:
       uninitialized constant Puppet::ResourceApi::BaseContext

@Ramesh7 Ramesh7 force-pushed the CONT-576 branch 3 times, most recently from 62930bd to c2aa17a Compare May 23, 2023 14:56
@jordanbreen28 jordanbreen28 merged commit 02f09d6 into main May 23, 2023
38 checks passed
@jordanbreen28 jordanbreen28 deleted the CONT-576 branch May 23, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants