Refactor to put a knob on all parameters #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 4, 2013 13:35
…for autoloading from hiera put a handle on all the params of the class in init.pp so that they can be autoloaded from hiera, and easily fed to the class from a profile class
we don't need these defines for this refactor. Removing for simplicity's sake
| $ssl = $mysql::ssl, | ||
| $ssl_ca = $mysql::ssl_ca, | ||
| $ssl_cert = $mysql::ssl_cert, | ||
| $ssl_key = $mysql::ssl_key, |
There was a problem hiding this comment.
This final comma causes Puppet 2.6 to fail. Could you remove the trailing comma on the last parameter?
…n puppet 2.6 Fix to config.pp. Remove trailing , on last parameter, which breaks in puppet 2.6
| @@ -11,14 +73,42 @@ | |||
| # | |||
| # Sample Usage: | |||
| # | |||
| class mysql ( | |||
| $package_name = $mysql::params::client_package_name, | |||
There was a problem hiding this comment.
Removing $package_name as a parameter is the correct thing to do, but will cause it to be backwards incompatible. Could you let the mysql class continue to accept $package_name in addition to $client_package_name and throw a deprecation warning using the warning() function if someone is using $package_name?
$package_name = undef,There was a problem hiding this comment.
Noting that this is resolved with further commits, but github still shows the comment.
added 3 commits
April 24, 2013 15:35
Removal of the ambiguously named package_name parameter, without having a version provide a deprecation warning for a reasonable amount of time seems unreasonable. As Hunner suggests, adding a workaround variable to init.pp and use that as package name gives us the ability to warn users about the upcoming deprecation, while still maintaining backwards compatibility.
…ards compatibility with Puppet2.6
hunner
added a commit
that referenced
this pull request
Apr 25, 2013
Refactor to put a knob on all parameters
pmcmaw
pushed a commit
to pmcmaw/puppetlabs-mysql
that referenced
this pull request
Mar 3, 2021
…ve_rhel5_centos5 (IAC-1351) Remove CentOS 5 & RHEL 5 from provision.yaml file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-scopes all the variables in the params class to be mysql:: scoped parameters, which default to the values in params.pp. The stock behavior should not change, but one can now (with puppet3 or with a profile class) alter the value of variables which previously would require manual changes to module-owned files.
The intention here is that people will be able to keep up to date with the forge module with greater ease as they will not need to make changes to the module to feed it customizations.