Type mysql_grant fixed, spec test created #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are removing defaults_file, but there's no mention in your commit message of that. |
|
Right. Fixed before. I will update my commit message. |
|
Done. Can you merge? |
|
That's not what I meant. Those should be two different pull requests, or at least two different commits. |
the method to the global mysql.rb which is now included in every provider file. Class from the global mysql.rb file is a parent of every provider.
…alhost/*.* or foo@localhost/bar.* but NOT with root@localhost/@ which is the parsed value of "GRANT PROXY ON ''@'' TO 'root'@'localhost' WITH GRANT OPTION" grant line. New spec test was created for the type mysql_grant.rb
|
Done again :) |
igalic
added a commit
that referenced
this pull request
Nov 17, 2013
Type mysql_grant fixed, spec test created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type mysql_grant was limited to work only with resource names foo@localhost/. or foo@localhost/bar.* but NOT with root@localhost/@ which is the parsed value of "GRANT PROXY ON ''@'' TO 'root'@'localhost' WITH GRANT OPTION" grant line.
New spec test was created for the type mysql_grant.rb
defaults_file methods removed from every provider (old & new) and moved
the method to the global mysql.rb which is now included in every provider
file.