fixed a problem with the mysql_database provider #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please look at the failing Travis tests? I'm having trouble discerning whether they are failing because of your commit. |
|
Sorry about that. There were 2 tests expecting the old queries with the I'm still not sure what the |
|
Let's land this and see what happens. |
igalic
added a commit
that referenced
this pull request
Jan 25, 2014
fixed a quoting problem with the mysql_database provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two problems with the query generated in the
instancesmethod of the mysql_database provider. They show themselves when we try to remove the default accounts:%_databasepart of the query.nameparameter inside the array passed tomysqlcommand is intended to do, but it appears to be generating queries with the database name in it, such asshow variables like '%_database' information_schema, which won't run.This pull request fixes both of those issues.