Do the right thing when fqdn==localhost #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '@%']: | ||
| ensure => 'absent', | ||
| require => Anchor['mysql::server::end'], | ||
| } | ||
| if ($::fqdn != 'localhost') { |
There was a problem hiding this comment.
What if fqdn is localhost.localdomain? It would create duplicates in that case.
|
Could you squash this, update as per comments, and add rspec-puppet tests for the cases of fqdn being localhost, localhost.localdomain, and neither? Thanks! |
dveeden
force-pushed
the
account_localhost
branch
from
05442f9
to
216442a
Compare
This is because the root@localhost account is already defined. Remove localdomain accounts if fqdn is localhost
dveeden
force-pushed
the
account_localhost
branch
from
216442a
to
c04fed1
Compare
|
I've added some tests. Please check them as I'm not too familiar with rspec. |
tphoney
added a commit
that referenced
this pull request
Jan 22, 2015
Do the right thing when fqdn==localhost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure not to declare root@localhost and @localhost if the fqdn is 'localhost'
Also remove root@localhost.localdomain and @localhost.localdomain in that case