Add type & provider for managing plugins #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| it 'should find the plugin' do | ||
| shell("select plugin_name from information_schema.plugins where plugin_name='auth_socket'") do |r| |
There was a problem hiding this comment.
I don't think this would work, since shell() shells out to the sh shell, not the mysql shell. Should look more like https://github.com/puppetlabs/puppetlabs-mysql/blob/master/spec/acceptance/types/mysql_user_spec.rb#L27
There was a problem hiding this comment.
The shell() command will actually call out to a sh, so you would have to call shell('mysql -e "select plugin_name ...') or something to get the mysql output.
There was a problem hiding this comment.
Good catch. I've updated that line.
|
Could you add a section for this to the README? |
|
I've added a section to the README |
igalic
added a commit
that referenced
this pull request
Jan 27, 2015
Add type & provider for managing plugins
|
thaaaaaaaaanks @dveeden! |
cmurphy
pushed a commit
to cmurphy/puppetlabs-mysql
that referenced
this pull request
Jan 27, 2015
underscorgan
pushed a commit
that referenced
this pull request
Jan 27, 2015
Fix acceptance tests from #641
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics for working with MySQL plugins works.
Some plugins like auth_socket and validate_password are shipped with the server. The enterprise edition also has a auditlog, encryption and threadpool plugin. There are also third-party plugins which add things like JSON parsing, etc.