Enabled usage of the $ntpsigndsocket parameter, for socket signing. #304
Conversation
|
@powertoaster This looks good but can you please remove the updates to the CHANGELOG and the metadata version bump? We will take care of that part when we prep the release. Thanks! |
|
Done, thank you all for your help and patience with me. |
| @@ -225,6 +225,10 @@ Tells Puppet to use non-standard minimal poll interval of upstream servers. Vali | |||
|
|
|||
| Tells Puppet to use non-standard maximal poll interval of upstream servers. Valid options: 3 to 16. Default option: undef, except FreeBSD (on FreeBSD `maxpoll` set 9 by default). | |||
|
|
|||
| ####`ntpsigndsocket` | |||
|
|
|||
| Tells NTP to sign packets using the socket in the ntpsigndsocket path. NTP must be configured to sign sockets for this to work. | |||
There was a problem hiding this comment.
Can you add a line here describing what the parameter should take and what the Default is? Similar to the descriptions provided by the other parameters around it.
|
@powertoaster No problem. Thank you for contributing! I'm sorry I didn't catch this before my last comment. But I've made one more request in the README. Thanks again! |
|
Added the requested comments, I want to thank everyone at Puppet for letting me flail around here a little. I have learned a great deal about GIT and contributing to a project in the process. Way more than I would have had one of you cleaned up my little mistakes for me. Oh, and puppet rules. |
|
@powertoaster The README still needs a blurb about the Parameter input and default. Sorry for the back and forth. :( |
|
I pushed it to my repo, I can see the changes there but for some reason they are not appearing here. I frankly am not sure how to force them, all of my other changes to the pull request code came over automatically. All I could do at this point is close the pull and redo it. |
|
@powertoaster Actually.. they appear to have updated, but apparently didn't resolve my comment. weird. |
| ####`ntpsigndsocket` | ||
|
|
||
| Tells NTP to sign packets using the socket in the ntpsigndsocket path. NTP must be configured to sign sockets for this to work. | ||
| Valid options a path to the socket directory, in the case of Samba it would be: ntpsigndsocket = usr/local/samba/var/lib/ntp_signd, there is no default. |
There was a problem hiding this comment.
Typically.. you'd say that Default value: undef as is the case here.
|
@powertoaster Apologies for nitpicking the docs, I just want to maintain consistency through the README when new parameters or features are added. Thanks for your patience! |
|
Should be good to go |
|
Thanks @powertoaster ! |
Enabled usage of the $ntpsigndsocket parameter, for socket signing.
I need to be able to sign NTP packets and this enables the parameter.