not to setup the package if it is not required

[guessi]

if their enabled option is controlled by $is_controller or $is_storage, maybe we can just not setup them.

[cmurphy]

The network node needs this class in order to set authentication credentials in /etc/neutron/neutron.conf. Could you make the if $is_controller just surround the neutron::server::notifications class, and then you can calso add package_ensure => $is_controller here? As in

class { '::neutron::server':
   auth_host           => $::openstack::config::controller_address_management,
   auth_password       => $::openstack::config::neutron_password,
   database_connection => $::openstack::resources::connectors::neutron,
   package_ensure      => $is_controller,
   enabled             => $is_controller,
   sync_db             => $is_controller,
   mysql_module        => '2.2',
 }

if $is_controller {
  class { '::neutron::server::notifications':
    # ...

[guessi]

Hi @cmurphy ,
I've update the commit for neutron.pp as your suggestion, please check it again,
do you need to squash commits into one, please let me know, thanks for you suggestion :)

[cmurphy]

Thanks @guessi, I squashed this and merged it in c7d77de

[guessi]

thanks :)