This repository has been archived by the owner on May 14, 2019. It is now read-only.
Remove setup classes #182
Merged
Remove setup classes #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having a class that sets up a single hard-coded image is not very useful, except for demos. This change moves the image data into the example hiera files and uses create_resources on a hash of data to create as many images as the user wants. We move this into openstack::profile::glance::api since now a one-line function does not need its own class.
cmurphy
force-pushed
the
remove_setup_classes
branch
from
4515be2
to
7f691f0
Compare
The openstack::setup::router and openstack::setup::sharednetwork classes only create two networks and one router with very little configuration options. This change moves the network data into the example hiera files and uses create_resources on a hash to create as many networks, subnets, and routers are the user wants. We move this into openstack::profile::neutron::router since these resources will always reside on the network node.
cmurphy
force-pushed
the
remove_setup_classes
branch
from
7f691f0
to
308643a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #179.
The goal here is to enhance configurability while reducing code complexity. The user
should now be able to create as many images or networking resources as they want,
instead of having them hard coded. We still provide the original values as examples
in hiera, but default to creating nothing.
This is backwards incompatible as it will no longer create these resources by default.