Fix package task for yum when passing version

[cliveweir]

This fixes issue #236

Summary

If the (optional) version parameter is passed the package $name variable is overwritten with "name-version". This format is required by yum when installing/uninstalling/upgrading a specific package version but it is not compatible when calling rpm -q --whatprovides $name - which requires the name only.

Solution

Don't overwrite $name with name-version, use a new variable instead.

Testing

❯ bolt task run package -t 'fiendish-sister.delivery.puppetlabs.net' --params '{"action":"install", "name":"vim-enhanced", "version":"2:8.0.1763-15.el8"}'

Started on fiendish-sister.delivery.puppetlabs.net...
Finished on fiendish-sister.delivery.puppetlabs.net:
  {
    "status": "installed",
    "version": "8.0.1763-15.el8"
  }
Successful on 1 target: fiendish-sister.delivery.puppetlabs.net
Ran on 1 target in 18.03 sec

❯ bolt task run package -t 'fiendish-sister.delivery.puppetlabs.net' --params '{"action":"upgrade", "name":"openldap", "version":"2.4.46-15.el8"}'

Started on fiendish-sister.delivery.puppetlabs.net...
Finished on fiendish-sister.delivery.puppetlabs.net:
  {
    "old_version": "2.4.46-9.el8",
    "version": "2.4.46-15.el8"
  }
Successful on 1 target: fiendish-sister.delivery.puppetlabs.net
Ran on 1 target in 13.87 sec

❯ bolt task run package -t 'fiendish-sister.delivery.puppetlabs.net' --params '{"action":"uninstall", "name":"vim-enhanced", "version":"2:8.0.1763-15.el8"}'

Started on fiendish-sister.delivery.puppetlabs.net...
Finished on fiendish-sister.delivery.puppetlabs.net:
  {
    "status": "uninstalled"
  }
Successful on 1 target: fiendish-sister.delivery.puppetlabs.net
Ran on 1 target in 12.82 sec

Affected Area

Package task (for yum only)

[carabasdaniel]

👍 LGTM