Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deletes class parameters from PE Master (other groups too?) #130

Closed
reidmv opened this issue Oct 16, 2020 · 0 comments · Fixed by #132 or #134
Closed

Upgrade deletes class parameters from PE Master (other groups too?) #130

reidmv opened this issue Oct 16, 2020 · 0 comments · Fixed by #132 or #134

Comments

@reidmv
Copy link
Contributor

reidmv commented Oct 16, 2020

Bug Description

When running peadm::upgrade, any class parameter configuration added by the user to PE Master, such as code_manager_auto_configure=true, will be deleted.

Expected Behavior

User configuration of class parameters in PE Master and other built-in groups should be preserved by peadm::upgrade.

@reidmv reidmv added the bug label Oct 16, 2020
reidmv added a commit that referenced this issue Nov 2, 2020
Users may have their own config data specified for the PE Master group.
This commit ensures that when peadm enforces node group configuration
including config data on the PE Master group, it merges required config
into existing user data to avoid configuration loss.
reidmv added a commit that referenced this issue Nov 2, 2020
Users may have their own config data specified for the PE Master group.
This commit ensures that when peadm enforces node group configuration
including config data on the PE Master group, it merges required config
into existing user data to avoid configuration loss.
reidmv added a commit that referenced this issue Nov 2, 2020
Users may have their own config data specified for the PE Master group.
This commit ensures that when peadm enforces node group configuration
including config data on the PE Master group, it merges required config
into existing user data to avoid configuration loss.
reidmv added a commit that referenced this issue Nov 2, 2020
GH-130 Fix overwrite of user config data
reidmv added a commit that referenced this issue Nov 2, 2020
At least for the configuration data attribute. A long-term solution is
going to need to be modifying WhatsARanjit/node_manager to support a
`purge` parameter to control this behavior on various different
attributes.
reidmv added a commit that referenced this issue Jan 28, 2021
Use node_manager's new purge_behavior parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant