Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When PE installer fails on upgrade, upgrade plan should halt #71

Closed
reidmv opened this issue Mar 16, 2020 · 0 comments · Fixed by #75
Closed

When PE installer fails on upgrade, upgrade plan should halt #71

reidmv opened this issue Mar 16, 2020 · 0 comments · Fixed by #75

Comments

@reidmv
Copy link
Contributor

reidmv commented Mar 16, 2020

Describe the Bug

When the upgrade plan runs and the installer fails, the upgrade does not stop.

Expected Behavior

The upgrade should stop when the PE installer emits a failed exit code.

Additional Context

Because in the Extra Large architecture there are circumstances in which the installer is expected to fail, be careful in fixing this that for expected installer failures, plans still continue.

The pe_install task should be updated with failure condition parameters, probably.

puppetlabs-peadm/tasks/pe_install.sh

Lines 23 to 27 in 9b59b32

if [ ! -z "$PT_peconf" ]; then
/bin/bash "${tgzdir}/${pedir}/puppet-enterprise-installer" -y -c "$PT_peconf"
else
/bin/bash "${tgzdir}/${pedir}/puppet-enterprise-installer" -y
fi

@reidmv reidmv added the bug label Mar 16, 2020
reidmv added a commit that referenced this issue Mar 18, 2020
@reidmv
Fail peadm::pe_install task when installer fails
09f9622 
The peadm::pe_install task as written will probably never technically
fail, even when the puppet-enterprise-installer script exits non-zero.

This commit updates the task to exit with whatever exit code the
puppet-enterprise-installer script exited with. Not a perfect fix but a
step in the right direction.

Fixes #71
@reidmv reidmv mentioned this issue Mar 21, 2020
Merged
reidmv added a commit that referenced this issue Mar 21, 2020
@reidmv
Merge pull request #75 from puppetlabs/GH-71
deea897 
Fail peadm::pe_install task when installer fails
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fail peadm::pe_install task when installer fails puppetlabs/puppetlabs-peadm
1 participant
@reidmv