Infra upgrade improvement #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code 11 means "PuppetDB sync in progress but not yet complete". We don't want to abort upgrade on this code. Commit also refactors task to make it easier to unit test.
Print better data when something goes wrong. Example: when the token used to connect to the orchestrator is not permitted to perform the requested operation.
This feels more user-defined and unlikely to be affected by future Bolt product changes, compared to relying on whether or not a tty is present.
timidri
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch exit code 11, indicating PuppetDB is not fully synced, but the replica is otherwise ready to go.
In order to boost confidence that this is working correctly, the puppet_infra_upgrade task has been refactored to support unit testing, and unit tests have been added.