Added ability fo fully bootstrap Code manager #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reidmv
force-pushed
the
code_manager
branch
from
d886542
to
60c0409
Compare
|
@dylanratcliffe I refactored these commits a little to:
Please take a look and let me know what you think of the adjustments. Happy to chat real-time if you want! Just ping me on Slack. :) |
reidmv
force-pushed
the
code_manager
branch
from
60c0409
to
48a91a3
Compare
reidmv
force-pushed
the
code_manager
branch
from
48a91a3
to
6491b78
Compare
reidmv
force-pushed
the
code_manager
branch
from
6491b78
to
b82f6ce
Compare
added 2 commits
September 27, 2019 17:38
Provide parameters that match 80% of users' experience configuring code-manager. Namely, add r10k_remote and r10k_private_key settings.
reidmv
force-pushed
the
code_manager
branch
2 times, most recently
from
e9dd8f7
to
1d98389
Compare
|
@dylanratcliffe updated with the changes we discussed. Have not tested this code yet but logically it should be complete. Thoughts? |
reidmv
force-pushed
the
code_manager
branch
2 times, most recently
from
ee6e2df
to
8026086
Compare
Observationally: - We ALWAYS want to configure Code Manager - We ALWAYS want the private key location configured the same - We can use pe_conf_data to override anything if we need to - We don't want magic To that end, this commit simplifies the r10k private key input to require that the key content is supplied OR the path to a local file containing the key. The two parameters are different, and mutually exclusive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to properly bootstrap code manager by making the following major changes:
In order to get this working we needed to improve a few things, mostly around how
pe.confis generated:pe.conffrom templates to fully dynamic config files$pe_conf_datato allow users to specify anype.confsettings without requiring template changes$pe_conf_dataalso allows the hardcoded settings likepuppet_enterprise::profile::puppetdb::database_hostto be overridden if required for some reason