V4 #26
Merged
V4 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the interface a bit, optimizing it for the 90% use case.
This helps clarify the intended user interface classes, currently provision and upgrade.
Previously, it did not include module deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big changes here:
Simplify the UX to two top-level actions:
In doing that, move all subplans (not intended to be called directly by most users) into subdirectories. For install and configure actions, move them to "unit" subdirectory. Open to ideas for other directory names.
In the metadata.json we already only supported this version of PE XL with PE 2019.x and newer. This change makes it technically explicit. This version of the module will no longer work with PE 2018.1.