Use node group apply

[reidmv]

Switch from doing hacky module downloading on the master and running puppet apply to using an apply() block in the plan.

[abuxton]

@reidmv still not sure why this uses node_group and downloads the module instead of pe_node_group which is built in to pe?

[reidmv]

@abuxton it's a little tricky, but the main reason is beause for an apply() block it doesn't really matter what Puppet code is installed on the target... The place the code is needed is whatever host you're running Bolt on.

Because the pe_node_group type comes from an internal-only PE module, it's very difficult to get access to unless you're running on a PE master or compiler. In the case of the pe_xl and installation, it's actually guaranteed that the module won't be available when you start installation.

Using a Forge module means that the end experience we'll have is the user checking out a Bolt project, running bolt puppetfile install to download and populate all module dependencies, and then running the plan.

[abuxton]

yeah I came back to say that after I figured it out running the code and prodding about! kind of annoying as only other workaround is getting customers to commit the pe_modules to their codebase (some do this anyway, but far from ideal)