Update parameter for puppetdb_database_host

[npwalker]

Previously, we laid down a parameter from a lower level class instead of the top level parameter from puppet_enterprise. The PE installer does not recognize the lower level class parameter but does recognize the puppet_enterprise parameter.

[npwalker]

This line in the puppetdb database host pe.conf should also be updated although I'm not clear if the installer will fully understand that.

https://github.com/puppetlabs/puppetlabs-peadm/blob/master/installer/puppetdb-database/pe.conf#L19

The pe.conf between the master and the puppetdb database host should be the same and if they can't be then I would consider it a bug in PE.

[reidmv]

The pe.conf between the master and the puppetdb database host should be the same and if they can't be then I would consider it a bug in PE.

I believe the problem here is that the bit that tells the installer to set up PostgreSQL is only puppet_enterprise::database_host. At present we're running the installer script on the host that'll serve the PuppetDB postgreSQL database.

We should probably just convert to staged bootstrapping for simplicity. 1) Set up a standard master, 2) use agent-installer and classification to set up a node to act as a postgresql host for PuppetDB, 3) reconfigure the master to use the new PuppetDB postgresql node, 4) clean up the PuppetDB database that was briefly used on the master to avoid future confusion.

[npwalker]

The installer will install postgresql on any of the puppet_enterprise::*_database_host parameters since 2018.1.

see https://github.com/puppetlabs/puppet-enterprise-modules/blob/irving/modules/pe_install/manifests/init.pp#L60-L63

I don't think there's any purpose to removing any databases from postgresql as the puppet code will add them back in.

[reidmv]

Oh, cool! Okay. I'll merge this for now. Can revert later if it causes problems.

[reidmv]

Needed to partially revert. See #36.