(PE-36789) R10k Known hosts upgrade path #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpartlow
reviewed
Sep 12, 2023
jpartlow
reviewed
Sep 12, 2023
Adding optional parameter for r10k known hosts Alerting user to set known hosts if they are upgrading to or past 2023.3
|
@ragingra should this still be a draft? |
CoMfUcIoS
approved these changes
Sep 14, 2023
|
@jpartlow if you are happy with it, please merge |
jpartlow
reviewed
Sep 14, 2023
jpartlow
reviewed
Sep 14, 2023
Noticed that the get_pe_conf/update_pe_conf functions were expecting a target but $primary_target is actually an array. So I went ahead added specs covering the basic cases for upgrade and r10k_known_hosts. They aren't the best specs due to difficulties testing write_file, upload_file and out_message, but they at least validate that the plan completes with r10k_known_hosts set.
|
Added upgrade specs because I found a breaking issue while fiddling with them. Would probably be good to add a github workflow that tests install/upgrade with r10k settings, validates puppet-code deploy, but that was more than I had time for. I did verify a manual standard upgrade from 2021.7.4 to 2023.3.0 with code manager setup still had working code deployment with r10k_known_hosts set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding optional parameter for r10k known hosts
Alerting user to set known hosts if they are upgrading to or past 2023.3
Summary
Provide a detailed description of all the changes present in this pull request.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
Changes include test coverage?
Have you updated the documentation?