Eliminate default private key parameter value #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have observed setting r10k_private_key by default can cause conflicts with advanced code manager configuration keys passed in by pe_conf_data. To avoid the need to zero-out the r10k_private_key value, if the top-level r10k_private_key settings are not given to peadm::provision, do not set a pe.conf value for r10k_private_key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have observed setting r10k_private_key by default can cause conflicts with advanced code manager configuration keys passed in by pe_conf_data. To avoid the need to zero-out the r10k_private_key value, if the top-level r10k_private_key settings are not given to peadm::provision, do not set a pe.conf value for r10k_private_key.