Node manager switch #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bwilcox I was looking at this, and wondering if trying to fix the issue upstream of the if statement will let us keep the number of logic checks down. Gonna try this build with extra-large. Can you take a look and see if you think the logic is sound? |
…present without a standalone puppetdb replica.
To try and avoid dealing with the complexity of PuppetDB database host picking at the end of the manifest, see if having a sane class parameter default solves the problem cleanly. If it does, we can do a simple switch on replica/no-replica to create the B groups.
It doesn't like having an optional parameter come before a non-optional one. Since parameters are moving around a bit, add some comments to clarify their intended usage.
|
@bwilcox I validated that this works great for Extra Large. Have you had a chance to glance over it for the Large use case? |
|
Tested w/ Large + HA. B groups are both created, look correct. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered a use case where compiler group B was not being created when the infrastructure did not have a puppetdb replica, but did have a master replica. This caused compilers classified for cluster B to not be classified since the group did not exist.
This update addresses that.