Set certnames to target names #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because the curl|bash installer overrides certname and server settings when installing. In the event a server needs to use a certname which is NOT the same as the system's configured hostname, the certname must be set manually at agent install time.
DRY up the code a bit
The only way to set the certname right now for hosts configured with the PE installer is to pre-stage a puppet.conf file with the certname value set. This commit does that for PE installer hosts in order to allow all infrastructure nodes to have their certnames set for them, based on the Bolt target name. If the target name is different from the IP address used to reach the host, then an inventory file should be used.
reidmv
force-pushed
the
preserve-certnames
branch
from
a9b47bc
to
c02b0fb
Compare
reidmv
changed the title
This commit removes the hard check that target names be equal to hostnames. This commit is in support of other changes added to allow the use of certnames which are not the hostname.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support the use case wherein the certname of a system should be set to something besides the hostname (such as when the DNS A records are friendly names, but the system hostname(s) are not), do not leave certname settings up to Puppet's defaults.
Instead, at install time set the certnames of each server in the infrastructure to the target name of the server.
This will require a little bit of creative decision making with regards to the precheck validator, which used to insist that hostname == target name, and would fail if there was a mismatch.