Fix incorrect task name in install plan #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* previously the install plan fails because the
insert_csr_extension was recently renamed and not updated.
Additionally, the parameter name changed and was also updated
in this commit which is required to complete the install.
logicminds
commented
Mar 31, 2020
| run_plan('peadm::util::insert_csr_extensions', $master_target, | ||
| extensions => { | ||
| run_plan('peadm::util::insert_csr_extension_requests', $master_target, | ||
| extension_requests => { | ||
| peadm::oid('peadm_role') => 'puppet/master', |
There was a problem hiding this comment.
Are these parameters here correct? @reidmv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously the install plan fails because the
insert_csr_extension was recently renamed and not updated.
Additionally, the parameter name changed and was also updated
in this commit which is required to complete the install.
Please verify the install.sh task usage is correct because I don't understand how it should be used.