Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "made print() call Py3 compliant, added checks for Py execs" #95

Merged
merged 1 commit into from May 15, 2020
Merged

Revert "made print() call Py3 compliant, added checks for Py execs" #95

merged 1 commit into from May 15, 2020

Conversation

ody
Copy link
Member

@ody ody commented May 15, 2020

The commit that I am reverting causes hard failures in newly deployed infrastructure via https://github.com/puppetlabs/puppetlabs-autope on GCP with CentOS 7. My suspicion is the addition of exit 1 upon detection that the file did exist, this fails the plan immediately but previously allowed to run to completion.

@ody ody requested a review from a team as a code owner May 15, 2020 20:04
@reidmv reidmv merged commit 6134727 into puppetlabs:master May 15, 2020
@reidmv
Copy link
Contributor

reidmv commented May 15, 2020

@ody merged 'cause if it's causing problems it should be fixed, but can you post more details about the problem? This is a simple enough script I think fixing it is probably trivial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants