(MODULES-3449) Stop Windows pxp-agent service #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iristyle
changed the title
| @@ -15,7 +15,13 @@ FOR /F "tokens=*" %%A IN ('tasklist /FI "PID eq %AGENT_PID%" /NH') DO set _task= | |||
| echo %_task% | findstr "No tasks are running" >nul | |||
| IF NOT %errorlevel% == 0 ( GOTO wait_for_pid ) | |||
|
|
|||
| start /wait msiexec.exe /qn /norestart /i "<%= @_msi_location %>" /l*v "<%= @_logfile %>" PUPPET_MASTER_SERVER="<%= @_puppet_master %>" | |||
| REM This *must* occur after Puppet Agent has finished applying its | |||
| REM prior catalog which manages the pxp-agent service state. | |||
There was a problem hiding this comment.
Should you mention why it must occur if it's so important? Unless the commit message is all that's required?
- Previously, upgrades could fail as a result of the pxp-agent service holding file locks. While we have been previously aware of the potential for this issue, given pxp-agent runs under nssm.exe on Windows, prior investigation had shown this to not be an issue on silent installations (see PA-65). However, in practice, while upgrading from puppet-agent 1.4.2 to puppet-agent 1.5.0, a running pxp-agent service is preventing installs from proceeding as requested with a 1603 failure. NSSM.exe is not affiliated with the pxp-agent service in the MSI and therefore the Restart Manager has no understanding that it will be later shutdown and unlocked. The solution is to simply request a `net stop pxp-agent` prior to running the MSI. It's very important that this be done *after* the puppet run responsible for triggering the upgrade has been performed. If the pxp-agent service shutdown occurs before, then the puppet run will typically turn it back on as part of managing the node with the Puppet Enterprise modules.
Iristyle
force-pushed
the
ticket/master/MODULES-3449-shutdown-pxp-agent-service-on-Windows-upgrades
branch
from
b6bf949
to
9caa377
Compare
|
👍 From me |
- Specifying the `x` for logging includes extra debugging information that can be useful when installations fail. For instance, it will produce more verbose information from the Restart Manager.
Iristyle
force-pushed
the
ticket/master/MODULES-3449-shutdown-pxp-agent-service-on-Windows-upgrades
branch
from
9caa377
to
fc2bd92
Compare
| REM sets its startup type, which prevents installs from proceeding. | ||
| REM This may fail on agents without pxp-agent, but since this is not | ||
| REM run interactively and the next command sets ERRORLEVEL, it's OK. | ||
| net stop pxp-agent |
There was a problem hiding this comment.
Did you determine the issue?
Also keep in mind that 3.x agents upgrading won't have this - so if it fails that should be ignored.
There was a problem hiding this comment.
Yes, was able to fix the upgrade with just the net stop pxp-agent here. Unfortunately, Restart Manager doesn't tell us what files are locked, though it's safe to assume its nssm.exe. Still don't know why this behavior deviates from what we observed in PA-65 though.
Your note about 3.x is in the comment block already.
Iristyle
deleted the
ticket/master/MODULES-3449-shutdown-pxp-agent-service-on-Windows-upgrades
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, upgrades could fail as a result of the pxp-agent service
holding file locks. While we have been previously aware of the
potential for this isssue, given pxp-agent runs under nssm.exe on
Windows, prior investigation had shown this to not be an issue on
silent installations (see PA-65).
However, in practice, while upgrading from puppet-agent 1.4.2 to
puppet-agent 1.5.0, a running pxp-agent service is preventing
installs from proceeding as requested with a 1603 failure. NSSM.exe
is not affiliated with the pxp-agent service in the MSI and therefore
the Restart Manager has no understanding that it will be later
shutdown and unlocked.
The solution is to simply request a
net stop pxp-agentprior torunning the MSI. It's very important that this be done after the
puppet run responsible for triggering the upgrade has been performed.
If the pxp-agent service shutdown occurs before, then the puppet run
will typically turn it back on as part of managing the node with the
Puppet Enterprise modules.