(MODULES-3636) Upgrade on non-English Windows

[Iristyle]

• The previous checks for PID running uses a combination of tasklist,
  findstr and some more cryptic batch-isms to detect if a puppet
  agent is currently executing (by PID). This check also relies on
  the English string "No tasks are running", because tasklist.exe
  doesn't set exitcodes as desired when the query is not a match.

  C:\Users\Administrator>tasklist.exe /FI "PID eq 1234" /NH
  INFO: No tasks are running which match the specified criteria.

  C:\Users\Administrator>echo %ERRORLEVEL%
  0

  There are a couple of alternative methods for achieving the
  desired functionality. The simplest is qprocess.exe:

  C:\Users\Administrator>qprocess 1234
  No Process exists for 1234
  C:\Users\Administrator>echo %ERRORLEVEL%
  1

  C:\Users\Administrator>qprocess 32936
  USERNAME SESSIONNAME ID PID IMAGE

  administrator console 1 32936 mmc.exe
  C:\Users\Administrator>echo %ERRORLEVEL%
  0

  Unfortunately qprocess is no longer available on Nano Server, so
  the next best option is wmic.exe, which exists everywhere.

  C:>wmic PATH Win32_Process where handle=1111 get handle /format:textvaluelist |
  findstr /I "Handle=1111"
  No Instance(s) Available.

  C:>echo %ERRORLEVEL%
  1

  The string 'Handle' appears everywhere, so no locale specific
  string parsing is required on non-English versions of Windows, such
  as German:

  C:\Users\moses>tasklist /FI "PID eq 1234" /NH
  INFORMATION: Es werden keine Aufgaben mit den angegebenen Kriterien ausgeführt.

  C:\Users\moses>echo %ERRORLEVEL%
  0

[ferventcoder]

Looks good!

[Iristyle]

@ferventcoder asked about Nano... Nano doesn't have qprocess.exe sadly, but it does have wmic.exe - updating accordingly.

[Iristyle]

We tested that "Handle=PID" appears on English and German... not sure about French or other languages.

Since it's a WMI property, I doubt that it's localized - but we might make the code a little more resilient if we just look for =PID instead of Handle=PID.

Thoughts @puppetlabs/windows

[ferventcoder]

I thought you said findstr.exe also wasn't on nano?

[Iristyle]

find.exe is not available, but findstr.exe is fortunately

[aharden]

The current version of this template isn't working for me on WS2012 R2/Japanese w/ PE 3.8.3 agent. Symptoms are that the Puppet Agent service stops after the first agent run after puppet_agent is classified. The new agent installer is downloaded, but installation doesn't happen. I haven't looked into this further. The "chcp 437" method we were talking about in #134 was working for me.

UPDATE: after changing the %ERRORLEVEL% check (which was now backwards), @aharden has confirmed this works now on Japanese Windows.