Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MODULES-4236) Disable proxy for yum repo as it will not pass through to Puppet Server and will not hand over the certs. #153

Merged
merged 1 commit into from Dec 20, 2016
Merged

(MODULES-4236) Disable proxy for yum repo as it will not pass through to Puppet Server and will not hand over the certs. #153

merged 1 commit into from Dec 20, 2016

Conversation

cyberious
Copy link
Contributor

  • We have system wide proxy for all repos and this is critical for us so we can use the module

@MikaelSmith
Copy link
Contributor

Sometimes sourcepath points to a public url. We should probably only disable proxy when source points to a puppet master.

@cyberious
Copy link
Contributor Author

So what do you think is a viable check for internet? not using port 8140? We override the agent source b/c we use an haproxy and in case one gets overloaded.

@MikaelSmith
Copy link
Contributor

That's tricky isn't it. Not using port 8140 might be the best we can do. Alternatively make disabling the proxy a param that can be overridden.

Disable proxy for yum repo as it will not pass through to Puppet Serv…
7eb4499 
…er and will not hand over the certs.

- We have system wide proxy for all repos and this is critical for us so we can use the module
@cyberious
Copy link
Contributor Author

Updated to have as a parameter defaulting to false to maintain the current behavior. Only currently affects redhat

@MikaelSmith MikaelSmith changed the title Disable proxy for yum repo as it will not pass through to Puppet Server and will not hand over the certs. (MODULES-4236) Disable proxy for yum repo as it will not pass through to Puppet Server and will not hand over the certs. Dec 20, 2016
@MikaelSmith MikaelSmith merged commit 5d8dda1 into puppetlabs:master Dec 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikaelSmith MikaelSmith MikaelSmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyberious @MikaelSmith