updated unless condition on Suse/Redhat GPG key imports to ensure downcasing

[exodusftw]

the current code on Suse simply converts all letters to the character 'a' and causes each run to re-import keys - so just for consistency sake, setting redhat/suse to both use the [:upper:] [:lower:] syntax

• edit - I should clarify - this doesn't happen on all systems, but the behavior appears to occur on older versions of coreutils

[exodusftw]

Just to show an example:

root@examplehost:/tmp $ rpm -qf /usr/bin/tr
coreutils-8.12-6.25.31.1

root@examplehost:/tmp $ cat /etc/*release
SUSE Linux Enterprise Server 11 (x86_64)
VERSION = 11
PATCHLEVEL = 3

root@examplehost:/tmp $ echo "ABCDEFG" | tr [A-Z] [a-z]
aaaaaaa

root@examplehost:/tmp $ echo "ABCDEFG" | tr A-Z a-z
abcdefg

root@examplehost:/tmp $ echo "ABCDEFG" | tr [:upper:] [:lower:]
abcdefg

[puppetcla]

Waiting for CLA signature by @exodusftw

@exodusftw - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

[MikaelSmith]

Thanks. I've tried this in CentOS 4, RedHat 7, and SLES 10. I suspect it's pretty universal.

[MikaelSmith]

@highb any concerns?

[MikaelSmith]

Created https://tickets.puppetlabs.com/browse/MODULES-3894 to track this.

[highb]

👍 from me