(MODULES-3872) add acceptance test for manage_repo param #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MosesMendoza
force-pushed
the
MODULES-3953/master/acceptance_for_manage_repo_param
branch
from
9ad396b
to
7a3d562
Compare
MosesMendoza
changed the title
|
Relevant output from a run against a rhel agent: https://gist.github.com/MosesMendoza/c35cc6d5b3b9fcdb21924161c88b214c |
This commit adds tests to the acceptance test suite in `class_spec.rb` for confirming that the manage_repo parameter does, in fact, do what it says. Specifically, we test that puppet created the repo by applying the 'puppet_agent' class with no params (implying default value of true for `manage_repo`) and then specifically ensuring the repo present with puppet and catching (failing) on any resultant changes. Then we remove the repo configuration and apply the puppet agent class again but with `manage_repo => false`, and ensure that the repo configs are not re-created (again by catching changes).
MosesMendoza
force-pushed
the
MODULES-3953/master/acceptance_for_manage_repo_param
branch
from
7a3d562
to
4bb954d
Compare
|
Relevant output from a run against an ubuntu agent: https://gist.github.com/MosesMendoza/5a81d5a2842598a5f195c5db99831ccb |
|
CLA signed by all contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds tests to the acceptance test suite in
class_spec.rbforconfirming that the manage_repo parameter does, in fact, do what it says.
Specifically, we test that puppet created the repo by applying the
'puppet_agent' class with no params (implying default value of true for
manage_repo) and then specifically ensuring the repo present with puppet andcatching (failing) on any resultant changes. Then we remove the repo
configuration and apply the puppet agent class again but with
manage_repo => false, and ensure that the repo configs are not re-created (again by catchingchanges).