(FM-5815) Prep for 1.3.1 release #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 15, 2016 15:23
This adds the puppet-blacksmith gem, which is used by our automated release tooling to ship modules. This also duplicates the `test` group as `development`, since that is the preferred name going forward. We'll keep the `test` alias for now, since it doesn't hurt anything.
[ci skip]
MikaelSmith
reviewed
Nov 16, 2016
| @@ -11,6 +11,7 @@ group :test do | |||
| gem 'metadata-json-lint', '~> 0.0' | |||
| gem 'rspec-puppet-facts', '~> 1.3' | |||
| gem 'semantic_puppet', '0.1.3' | |||
| gem 'puppet-blacksmith', '>= 3.4.0', :require => false, :platforms => 'ruby' | |||
There was a problem hiding this comment.
This looks like it might be a problem for Travis.
There was a problem hiding this comment.
See https://travis-ci.org/puppetlabs/puppetlabs-puppet_agent/builds/176248555. We should use a PR for merge-up to master to ensure that gets fixed.
There was a problem hiding this comment.
Ugh, yup. I'll re-open this without the blacksmith change - we can get it on to master after. This was sort of a preemptive change.
There was a problem hiding this comment.
Oh wait, this is merged, not closed. Nevermind, then!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.