(MODULES-4241) Enable Windows acceptance testing #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still a WIP, but getting pretty close. I'm having trouble getting the uninstall working. |
MikaelSmith
force-pushed
the
MODULES-3205
branch
2 times, most recently
from
955600d
to
2c8b4fe
Compare
|
CLA signed by all contributors. |
MikaelSmith
force-pushed
the
MODULES-3205
branch
from
2c8b4fe
to
4ad9493
Compare
|
Darn, one scenario still fails. |
MikaelSmith
force-pushed
the
MODULES-3205
branch
from
4ad9493
to
7bba9a3
Compare
highb
suggested changes
Dec 22, 2016
| @@ -0,0 +1,9 @@ | |||
| Facter.add(:puppet_agent_appdata) do | |||
There was a problem hiding this comment.
Oh you should rebase these changes out of this PR.
highb
suggested changes
Dec 22, 2016
| @@ -45,6 +45,12 @@ | |||
| default => "${::system32}\\cmd.exe" | |||
| } | |||
|
|
|||
| if (member($::puppet_agent::service_names, 'puppet')) { | |||
Ensure the Puppet service is enabled and started on Windows after an upgrade when it's included in the `service` param by setting `PUPPET_AGENT_STARTUP_MODE=Automatic`. Fixes puppetlabs#197.
MikaelSmith
force-pushed
the
MODULES-3205
branch
2 times, most recently
from
c54c492
to
c424c95
Compare
Update test setup to work with Windows paths and install behavior.
MikaelSmith
force-pushed
the
MODULES-3205
branch
from
c424c95
to
a07948e
Compare
|
Just disabled the whole mcollective section, it needs some work. This should now pass. |
|
I ran with |
highb
approved these changes
Dec 22, 2016
|
👍 lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update test setup to work with Windows paths and install behavior.
Fixes #197. Depends on #200.