(MODULES-4521) Update suse GPG file location #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikaelSmith
suggested changes
Mar 14, 2017
| @@ -16,9 +16,9 @@ | |||
| } | |||
| '11', '12': { | |||
| # Import the GPG key | |||
| $legacy_keyname = 'RPM-GPG-KEY-puppetlabs' | |||
There was a problem hiding this comment.
Can you also update legacy_gpg_path and gpg_path to re-add the RPM- prefix? I did that for RedHat to avoid creating multiple files on machines that already have the key present.
There was a problem hiding this comment.
Updated. Thanks for the catch @MikaelSmith sorry I missed it.
This commit updates the file location for the GPG keys used on the SLES. The key files have moved from `RPM-GPG-KEY-puppetlabs` to `GPG-KEY-puppetlabs` previously. This commit simply brings this location current for the SLES platform so that the keys can be properly found.
johnduarte
force-pushed
the
issue/master/modules-4521-update-suse-key-ref
branch
from
f277a0a
to
34249c1
Compare
MikaelSmith
approved these changes
Mar 14, 2017
|
@MikaelSmith Does this address PE-19899 as well then ? |
|
Yes @jcoconnor this addresses PE-19899 |
|
👍 It looks consistent with the work in #216 |
|
CLA signed by all contributors. |
|
FYI: frankenbuild test passes Running the following: Yields: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the file location for the GPG keys used on
the SLES. The key files have moved from
RPM-GPG-KEY-puppetlabsto
GPG-KEY-puppetlabspreviously. This commit simply brings thislocation current for the SLES platform so that the keys can be
properly found.