(MODULES-6686) Fix puppet_agent_spec tests for Windows #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously many tests in classes/puppet_agent_spec.rb were not running on Windows due to a bug in rspec-puppet-facts. However in v1.9.0 of the gem it now adds better windows support, but the puppet_agent_spec.rb began running tests for Windows which then failed. This commit modifies the test fixtures and logic to only test things which make sense on Windows. Also voxpupuli/rspec-puppet-facts#68 meant that the order of the testing had to be determinstic, ensuring that Windows platforms were tested last.
glennsarti
force-pushed
the
fix-broke-stuff
branch
from
8827763
to
0d6b514
Compare
|
CLA signed by all contributors. |
MikaelSmith
approved these changes
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously many tests in classes/puppet_agent_spec.rb were not running on
Windows due to a bug in rspec-puppet-facts. However in v1.9.0 of the gem it
now adds better windows support, but the puppet_agent_spec.rb began running
tests for Windows which then failed. This commit modifies the test fixtures and
logic to only test things which make sense on Windows.
Also voxpupuli/rspec-puppet-facts#68 meant that the
order of the testing had to be determinstic, ensuring that Windows platforms
were tested last.