(MODULES-6688) Use travis for CI testing, instead of Jenkins #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
force-pushed
the
fix-broke-stuff
branch
from
50392ca
to
63921af
Compare
glennsarti
changed the title
|
This is in preparation for removing spec tests in Jenkins. This is the normal practice for Modules team. |
Previously the module was tested in both Travis and private Jenkins CI systems however this is no longer required. This commit moves the spec tests that are tested in Jenkins and moves them to Travis; * Only test puppet agent and ruby combinations that are installed in AIO installs * Split out validate and lint checking to only happen once per job not for all matrix cells * Now tests on Puppet latest 3.8, first 4.0, latest 4.7.x, 4.10.x and 5.x gems * The Hiera Gem needs to be set on Puppet 4.7.1 as it has incompatibilites with later hiera gem versions (4.4.2) * Brings the Travis CI config file into a similar format as that used by the PDK to make migration easier later. * The Travis file needs to remain unmanaged until it supports setting the bundler_args setting
glennsarti
changed the title
glennsarti
force-pushed
the
fix-broke-stuff
branch
from
63921af
to
9f309e4
Compare
|
CLA signed by all contributors. |
Iristyle
reviewed
Feb 27, 2018
| @@ -8,6 +8,40 @@ | |||
| .travis.yml: | |||
| unmanaged: true | |||
|
|
|||
| # Requires the bundler_args to be supported. | |||
There was a problem hiding this comment.
Why add this now if it can't be used?
There was a problem hiding this comment.
Saving myself (or someone else) future work. That's the only thing missing. PDK adds that by default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the module was tested in both Travis and private Jenkins CI systems
however this is no longer required. This commit moves the spec tests that
are tested in Jenkins and moves them to Travis;
matrix cells
later hiera gem versions (4.4.2)
to make migration easier later.
bundler_args setting