(MODULES-7480) Set default collection in params.pp using PE version #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekinanp
force-pushed
the
MODULES-7480
branch
6 times, most recently
from
629fa10
to
7c173bc
Compare
ekinanp
changed the title
ekinanp
force-pushed
the
MODULES-7480
branch
2 times, most recently
from
a3b441e
to
d72cb86
Compare
Previously, we'd hardcode the default collection to PC1 in the init.pp manifest for both PE and non-PE environments. This has a couple of issues: * It's impossible to make decisions based on the collection in PE updates, so as we change package names and paths things get hairy. * This is already seen with the fedora "f" in Puppet 6, and will soon be seen with the AIX unibuild * In Irving.3, we switched to correctly shipping "puppet5" repos instead of "PC1". This means the module now MUST be aware of how PE versions map to collections. This commit calculates the collection default in params.pp using the following logic * If we are in a non-PE environment OR our pe_version < 2018.1.3, use PC1 * Else if 2018.1.3 <= pe_version < 2018.2, use puppet5 * Else use puppet6 (pe_version >= 2018.2 here)
|
CLA signed by all contributors. |
speedofdark
approved these changes
Jul 18, 2018
smcclellan
approved these changes
Jul 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we'd hardcode the default collection to PC1 in the init.pp
manifest for both PE and non-PE environments. This has a couple of
issues:
updates, so as we change package names and paths things get hairy.
seen with the AIX unibuild
of "PC1". This means the module now MUST be aware of how PE versions
map to collections.
This commit calculates the collection default in params.pp using the
following logic