(MOD-7655) SLES support for install_agent tasks #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds logic to the install_shell.sh install task implementation to support installing puppet-agent on SLES platforms. Currently the supported platform versions are 11 and 12. Nodeset templates have been added for manual testing.
donoghuc
commented
Aug 21, 2018
| @@ -22,7 +22,7 @@ def inventory | |||
|
|
|||
| it 'works with version and install tasks' do | |||
| # test the agent isn't already installed and that the version task works | |||
| results = run_task('puppet_agent::version', 'default', config: config, inventory: inventory) | |||
There was a problem hiding this comment.
Changing from default to target allows multiple targets defined in hosts.yaml to be tested.
For example:
- Generate multiple hosts
beaker-hostgenerator sles11-64target.a-sles12-64target.a > hosts.yaml
hosts.yaml
---
HOSTS:
sles11-64-1:
pe_dir:
pe_ver:
pe_upgrade_dir:
pe_upgrade_ver:
hypervisor: vmpooler
platform: sles-11-x86_64
packaging_platform: sles-11-x86_64
template: sles-11-x86_64
roles:
- agent
- target
sles12-64-1:
pe_dir:
pe_ver:
pe_upgrade_dir:
pe_upgrade_ver:
hypervisor: vmpooler
platform: sles-12-x86_64
packaging_platform: sles-12-x86_64
template: sles-12-x86_64
roles:
- agent
- target
CONFIG:
nfs_server: none
consoleport: 443
pooling_api: http://vmpooler.delivery.puppetlabs.net/
- Run task acceptance tests against targets defined in hosts.yaml with
BEAKER_setfile
GEM_BOLT=true BEAKER_keyfile=~/.ssh/id_rsa-acceptance BEAKER_debug=true BEAKER_setfile=hosts.yaml bundle exec rake task_acceptance
When default is targeted instead of target the following error occurs:
Failure/Error: expect(res).to include('status' => 'success')
expected {"node" => "default", "result" => {"_error" => {"details" => {}, "issue_code" => "CONNECT_ERROR", "kind" => "pupp...msg" => "Failed to connect to default: getaddrinfo: Name or service not known"}}, "status" => "failure"} to include {"status" => "success"}
There was a problem hiding this comment.
Hadn't noticed this got rewritten to a single test case.
|
CLA signed by all contributors. |
MikaelSmith
approved these changes
Aug 21, 2018
MikaelSmith
approved these changes
Aug 21, 2018
| @@ -22,7 +22,7 @@ def inventory | |||
|
|
|||
| it 'works with version and install tasks' do | |||
| # test the agent isn't already installed and that the version task works | |||
| results = run_task('puppet_agent::version', 'default', config: config, inventory: inventory) | |||
There was a problem hiding this comment.
Hadn't noticed this got rewritten to a single test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds logic to the install_shell.sh install task implementation to support installing puppet-agent on SLES platforms. Currently the supported platform versions are 11 and 12. Nodeset templates have been added for manual testing.