(MODULES-8318) Update rspec-puppet, add yumrepo_core fixtures for puppet 6 #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yumrepo was removed from puppet 6 and is now bundled with AIO puppet-agents as the yumrepo_core module. The puppet 6 gem, however, cannot manage yumrepo resources out of the box; Adding yumrepo_core as a fixture allows spec tests to pass with the puppet gem at version 6+.
caseywilliams
force-pushed
the
MODULES-8318/update-specs
branch
2 times, most recently
from
dc4dd99
to
d1859e4
Compare
caseywilliams
changed the title
|
CLA signed by all contributors. |
speedofdark
approved these changes
Dec 10, 2018
ScottGarman
approved these changes
Dec 10, 2018
joshcooper
reviewed
Dec 11, 2018
| @@ -11,5 +11,7 @@ fixtures: | |||
| apt: | |||
| repo: "puppetlabs/apt" | |||
| ref: "2.3.0" | |||
| yumrepo_core: | |||
| repo: "puppetlabs/yumrepo_core" | |||
There was a problem hiding this comment.
FYI it's possible to make this conditional for 6.0 and up only, see puppetlabs/puppetlabs_spec_helper#258. I don't think this PR needs to change (since the latest version of yumrepo_core supports older puppet versions), but just something to keep in mind in the future.
There was a problem hiding this comment.
Thanks! I didn't know that -- I think I'll make a followup PR to do that, just in case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two commits here, both of which are updates to dependencies: