(MODULES-8318) Remove spec tests for puppet < 4 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
ekinanp
reviewed
Dec 20, 2018
| } | ||
| end | ||
| else | ||
| context 'on Puppet 4 or higher' do |
There was a problem hiding this comment.
Why's this test removed for Puppet versions > 4?
There was a problem hiding this comment.
I can't actually find stringify_facts at all anymore in the puppet 4+ docs. These deprecation notes for 3 suggest that it's still possible to set it to true there, though, so I will work on restoring this unless someone else has more info.
|
spec/classes/puppet_agent_windows_install_spec.rb also has some Puppet 3 stuff that should probably be removed. |
Upgrades from puppet 3 won't be supported in release 2.0 of this module. This removes spec tests specific to puppet < 4, and updates a few stubbed values to be more consistent with versions in puppet 4+.
caseywilliams
force-pushed
the
MODULES-8318/update-specs-master
branch
from
a48ddfe
to
bfc6a48
Compare
|
Ok, Windows specs are updated -- after talking with @branan, we decided it doesn't seem worth keeping tests around stringify_facts, since 3.y support will be gone in the 2.0 release. |
ekinanp
approved these changes
Jan 2, 2019
ScottGarman
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades from puppet 3 won't be supported in release 2.0 of this module.
This removes spec tests specific to puppet < 4, and updates a few
stubbed values to be more consistent with versions in puppet 4+.