(PE-25542) add RHEL8 to puppet agent module

[loopinu]

added red hat 8 to metadata.json & puppet_agent_osfamily_redhad_spec.rb

Please do not merge yet.

[ScottGarman]

LGTM, I'd recommend also updating the commit message to something more like what was done for Fedora 29 to follow our usual style: 1a53054

[donoghuc]

The current implementation of the puppet_agent::install task does not work for rhel 8. Specifically it tries to download http://yum.puppetlabs.com/puppet/puppet-release-el-8.noarch.rpm
That could be a problem with the implementation, specifically I see that http://yum.puppetlabs.com/puppet/el/8/x86_64/puppet-agent-6.2.0-1.el8.x86_64.rpm is available. Should we target that directory for installing the agent?

puppetlabs-puppet_agent/tasks/install_shell.sh

Lines 426 to 431 in 51fc09c

	"el")
	info "Red hat like platform! Lets get you an RPM..."
	filetype="rpm"
	filename="${collection}-release-el-${platform_version}.noarch.rpm"
	download_url="http://yum.puppetlabs.com/${collection}/${filename}"
	;;

To be clear I don't think this should block merging this. I just wanted to point out the shortcoming in the install task implementation.

[puppetcla]

CLA signed by all contributors.

[caseywilliams]

Acceptance upgrade tests fail here, but only because we haven't released a beta package for RHEL 8 in the puppet5 series (which is where we'd be upgrading to puppet6 from) -- I'm ready to merge this now, but I'll wait for another reviewer.

[caseywilliams]

@donoghuc I just saw your comment -- my understanding is that the invalid path that the task currently relies on is not the "official" download path, and that the second one you mention is correct for all platforms (although checking with Release Engineering may be helpful) -- I believe that the older paths there are kept intact for those who still rely on them (although I do find their presence confusing!)

[mwaggett]

release packages for el 8 have now been shipped, so downloading from http://yum.puppetlabs.com/puppet/puppet-release-el-8.noarch.rpm should work

[donoghuc]

Just confirmed that this now works!

[loopinu]

@donoghuc , @caseywilliams Thanks for reviewing this PR and thank you @mwaggett for the release packages.

Short question: Can this be merged independently or it has a dependency with PR: https://github.com/puppetlabs/puppetlabs-pe_repo/pull/554 ?

Thanks