(MODULES-8320) Remove old platforms #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekinanp
commented
Jan 31, 2019
| @@ -63,7 +59,7 @@ | |||
| command => "/usr/bin/ctrun -l none ${_installsh} ${::puppet_agent_pid} 2>&1 > ${_logfile} &", | |||
| } | |||
| } | |||
| } elsif $::operatingsystem == 'Darwin' and $::macosx_productversion_major =~ /^10\.(9|10|11|12|13)/ { | |||
| } elsif $::operatingsystem == 'Darwin' { | |||
There was a problem hiding this comment.
We don't need the regex check at the end because the puppet_agent::prepare class is included before the puppet_agent::install class, and that prepare class includes the Darwin OS family class which has the regex check
We no longer ship these platforms in the latest 5.5.x stream.
ekinanp
requested review from
caseywilliams,
mcdonaldseanp,
speedofdark and
ScottGarman
mcdonaldseanp
approved these changes
Jan 31, 2019
speedofdark
approved these changes
Jan 31, 2019
ScottGarman
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.