(FM-7628) Update install_puppet.ps1 to catch hanging pxp-agent processes #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
caseywilliams
approved these changes
Feb 21, 2019
branan
reviewed
Feb 21, 2019
| Write-Log "Waiting for pxp-agent processes to stop" | ||
| Get-Process -Name "pxp-agent" -ErrorAction SilentlyContinue | ForEach-Object { | ||
| if ($_) { | ||
| if (!$_.WaitForExit(120000)){ |
There was a problem hiding this comment.
What unit is this timeout in? Would be nice to have a comment with human-readable format
There was a problem hiding this comment.
We have seen cases with customers where after shutting down the pxp-agent service there are still pxp-agent processes open. This commit adds a workaround to the install_puppet.ps1 powershell script to wait for any open pxp-agent processes to close, and if they don't the upgrade script will stop before actually attempting the upgrade.
mcdonaldseanp
force-pushed
the
FM7628
branch
from
2b52b17
to
05202b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen cases with customers where after shutting down the pxp-agent
service there are still pxp-agent processes open.
This commit adds a workaround to the install_puppet.ps1 powershell script to
wait for any open pxp-agent processes to close, and if they don't the upgrade
script will stop before actually attempting the upgrade.