Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Allow stdlib 6.x #418

Merged
merged 2 commits into from Jul 19, 2019
Merged

(maint) Allow stdlib 6.x #418

merged 2 commits into from Jul 19, 2019

Conversation

rnelson0
Copy link
Contributor

A number of modules are now allowing stdlib 6.x and we expect some will require it. It would be great to get a new release after this PR so that a version of puppet_agent is available supporting stdlib 6.x. Thanks.

@puppetcla
Copy link

CLA signed by all contributors.

@geoffnichols geoffnichols requested a review from a team June 19, 2019 20:43
@oanatmaria
Copy link
Contributor

oanatmaria commented Jul 18, 2019

Hi Rob,

Thank you for your contribution. Could you please modify your commit message to : (maint) Allow stdlib 6.x ?

@rnelson0 rnelson0 changed the title Allow stdlib 6.x (maint) Allow stdlib 6.x Jul 18, 2019
@rnelson0
Copy link
Contributor Author

@oanatmaria Commit message amended.

@oanatmaria
Copy link
Contributor

Seems like the pipeline is failing, I will investigate it further.

metadata.json Outdated Show resolved Hide resolved
@rnelson0
Copy link
Contributor Author

rnelson0 commented Jul 18, 2019 via email

@oanatmaria
Copy link
Contributor

@rnelson0 yes, it should be >= 7.0.1 < 8.0.0 in order to work with stdlib 6.0.0

@rnelson0
Copy link
Contributor Author

@oanatmaria Sorry, I had a merge conflict. I also updated the .fixtures.yml this time, though.

@oanatmaria
Copy link
Contributor

oanatmaria commented Jul 18, 2019

@rnelson0
Copy link
Contributor Author

I missed the new apt dependency of puppetlabs/translate, I have added it to the fixtures file.

A number of modules are now allowing stdlib 6.x and we expect some will require it. It would be great to get a new release after this PR so that a version of puppet_agent is available supporting stdlib 6.x. Thanks.
@rnelson0
Copy link
Contributor Author

Yay, it passes travis again!

@puppetcla
Copy link

CLA signed by all contributors.

@oanatmaria oanatmaria merged commit c3e3e5c into puppetlabs:master Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants