New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(maint) Allow stdlib 6.x #418
Conversation
CLA signed by all contributors. |
Hi Rob, Thank you for your contribution. Could you please modify your commit message to : (maint) Allow stdlib 6.x ? |
@oanatmaria Commit message amended. |
Seems like the pipeline is failing, I will investigate it further. |
Should the range be `>= 7.0.1 < 8.0.0` then?
|
@rnelson0 yes, it should be |
@oanatmaria Sorry, I had a merge conflict. I also updated the |
Acceptance tests are passing now: https://jenkins-master-prod-1.delivery.puppetlabs.net/view/puppet-agent/view/puppetlabs-puppet_agent%20module/view/ad-hoc/job/forge-module_puppetlabs-puppet-agent-module_intn-sys_smoke-adhoc/51/ but it seems like there are some failures on Travis for unit tests. |
I missed the new apt dependency of puppetlabs/translate, I have added it to the fixtures file. |
A number of modules are now allowing stdlib 6.x and we expect some will require it. It would be great to get a new release after this PR so that a version of puppet_agent is available supporting stdlib 6.x. Thanks.
Yay, it passes travis again! |
CLA signed by all contributors. |
A number of modules are now allowing stdlib 6.x and we expect some will require it. It would be great to get a new release after this PR so that a version of puppet_agent is available supporting stdlib 6.x. Thanks.