Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-9846) fix install using cached catalog #437

Conversation

ciprianbadescu
Copy link
Contributor

In case a cached catalog requesting puppet agent installation is
applied, the install script executes msi install and service
restart each time is run.

With this correction, the puppet agent package version is checked
against aio_agent_version fact and install continues only if
there is no match.

@puppetcla
Copy link

CLA signed by all contributors.

@mihaibuzgau mihaibuzgau requested a review from a team September 13, 2019 10:41
@ciprianbadescu ciprianbadescu force-pushed the MODULES-9846/fix-cached-catalog-install branch from 6bc49d5 to 78392a9 Compare September 13, 2019 11:28
In case a cached catalog requesting puppet agent installation is
applied, the install script executes msi install and service
restart each time is run.

With this correction, the puppet agent package version is checked
against aio_agent_version fact and install continues only if
there is no match.
@ciprianbadescu ciprianbadescu force-pushed the MODULES-9846/fix-cached-catalog-install branch from 78392a9 to 2bea0fe Compare September 13, 2019 12:04
Copy link
Contributor

@GabrielNagy GabrielNagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GabrielNagy GabrielNagy requested a review from a team September 13, 2019 13:59
@gimmyxd gimmyxd merged commit 3aef2ff into puppetlabs:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants