Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(maint) Updated metadata.json with support for Windows Server 2019 #449

Merged
merged 1 commit into from Dec 6, 2019
Merged

Conversation

sootysec
Copy link
Contributor

Add WIndows Server 2019 to list of supported operating. Currently using on this OS

@puppetcla
Copy link

CLA signed by all contributors.

@gimmyxd
Copy link
Contributor

gimmyxd commented Oct 31, 2019

@ducksecops please update your commit message to start with a (MODULES) ticket number or maint for trivial changes

@gimmyxd gimmyxd requested a review from a team October 31, 2019 12:14
@sootysec sootysec changed the title Update metadata.json maint Updated metadata.json with support for Windows Server 2019 Nov 1, 2019
@gimmyxd
Copy link
Contributor

gimmyxd commented Nov 5, 2019

@ducksecops to be valid, the commit message should be something like:
(maint) Updated metadata.json with support for Windows Server 2019

you can do this by amending you current commit message:
git commit --amend -m "(maint) Updated metadata.json with support for Windows Server 2019"

and then force push to your branch.

We have a check that fails if the commit message does not match specific rules.

@sootysec sootysec changed the title maint Updated metadata.json with support for Windows Server 2019 (maint) Updated metadata.json with support for Windows Server 2019 Nov 5, 2019
@mihaibuzgau mihaibuzgau merged commit fd9337c into puppetlabs:master Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants