(MODULES-10308) Allow downgrades when using apt #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the install task to allow for downgrading the Puppet agent when installing with `apt`. This aligns the behavior of the task with other package handlers, such as `rpm`, that allow for downgrading the Puppet agent version.
beechtom
force-pushed
the
GH-1208-puppet-agent-install
branch
from
c449bf7
to
8599b8c
Compare
beechtom
changed the title
|
CLA signed by all contributors. |
|
Tested on a debian 10 machine and it is working as expected. |
Dorin-Pleava
approved these changes
Dec 10, 2019
|
@beechtom I dont think this will work downgrading across platform versions (IE 6 to 5) even with the |
|
I dont think the change will hurt anything and will be fine to add in a release. I just dont think the functionality fully works as described. |
|
@gimmyxd I would revert the PR for release, and I'll work on getting acceptance tests written. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the install task to allow for downgrading the Puppet agent
when installing with
apt. This aligns the behavior of the task withother package handlers, such as
rpm, that allow for downgrading thePuppet agent version.
Part of puppetlabs/bolt#1208