(MODULES-10979) Release prep for 4.5.0 #547
Conversation
Update supported platforms in metadata.json, bump version and add changelog.
PDK 2 has been released which now accepts Facter 4, so we can use it now.
| @@ -118,7 +116,7 @@ | |||
| "requirements": [ | |||
| { | |||
| "name": "puppet", | |||
| "version_requirement": ">= 4.7.0 < 8.0.0" | |||
| "version_requirement": ">= 6.0.0 < 8.0.0" | |||
There was a problem hiding this comment.
We should still let people upgrade their older nodes using this module. So I think we should not update this. Or if we want to drop compatibility, it should be a major release.
I guess this also applies for older platforms, we should verify how people can check what version of puppet-agent module they can use to upgrade and if forge provides the needed information.
Never mind, users would still be able to install it on unsupported platforms/puppet versions but we can't guarantee that it would work since we're not testing on those. I think it is good that metadata.json contains only the supported platforms and puppet versions.
On that note, https://github.com/puppetlabs/puppetlabs-puppet_agent/blob/main/acceptance/tests/test_upgrade_puppet5_to_puppet6.rb (maybe other tests need to be adapted for puppet 6/7) is not relevant anymore, if we no longer state that puppet 5 is supported.
Update supported platforms in metadata.json, bump version and add changelog.