New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(MODULES-11060) Add Debian 11 testing support to install task #572
(MODULES-11060) Add Debian 11 testing support to install task #572
Conversation
tasks/install_shell.sh
Outdated
@@ -614,6 +614,7 @@ case $platform in | |||
"8") deb_codename="jessie";; | |||
"9") deb_codename="stretch";; | |||
"10") deb_codename="buster";; | |||
"testing") deb_codename="bullseye";; # FIXME: to be fixed when Debian is released and major_version is changed to 11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately this won't work with the modules team setup as the matrix for it is automatically generated from the metadata file, with the resulting machine that is provisioned being clearly labelled as 11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Debian 11 is planned to be released middle of August and then major_version
will be updated to 11
instead of testing
.
Do you have any proposal on how to fix this in the meantime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested and for our setup 11 seems to work fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"10") deb_codename="buster";;
"11") deb_codename="bullseye";;
Adding the above to the code in my fixtures allowed me to install the agent on my docker machine and the acceptance tests ran fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If testing
is required for the setup that you are using, could we just include both? And then removed testing when it is no longer needed, it seems like the simplest option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do 11|testing)
until after the official release. The docker images return "11" indeed, but our vmpooler boxes return "testing".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated PR to support both for now
b205ecb
to
4d29edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for getting this done so fast :)
we add this earlier for testing and it will be updated when the official image is released