(PUP-4921) Add PE version restriction #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MikaelSmith I'm not familiar with the PE version in module metadata. What does that end up being compared against? The supported path for PE ugprades is 3.8.1 -> 2015.2.0. I'm also not sure what 5.0.0 would correspond to in PE. |
|
I'm following a pattern in puppetlabs-apt that says < 5.0. Maybe @mhaskel or @adreyer is better able to answer. Should I bump the minimum to 3.8.1? |
MikaelSmith
force-pushed
the
bug/master/PUP-4921
branch
from
4fc65fd
to
10b7443
Compare
|
@MikaelSmith based on our conversation in the modules channel; this is so the forge can properly filter the module's availability for particular versions of PE, and the requirements look right to me. Merging. |
jpartlow
added a commit
that referenced
this pull request
Jul 27, 2015
(PUP-4921) Add PE version restriction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.