(PA-5242) Updates install tasks for puppet8 #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables the puppet_agent::install task to install puppet8-nightlies and removes support for puppet6, which is end-of-life.
The MODULES and FM Jira projects have been retired. This commit updates the commits check Rake task to no longer verify that commit summaries reference those projects, and instead adds the PA Jira project as an option instead.
joshcooper
reviewed
Mar 16, 2023
| # With prerelease puppet8, the puppet_agent::version task returns the wrong | ||
| # output. To temporarily work around this, we'll run puppet --version. | ||
| # Revert this change once Puppet 8.0.0 has been released. | ||
| # results = run_task('puppet_agent::version', 'target', {}) |
There was a problem hiding this comment.
maybe file a ticket so we don't forget?
There was a problem hiding this comment.
Yes, I'm keeping a running list of things we'll need to update after the final 8.0.0 release, I'll open a PA ticket about that today
joshcooper
approved these changes
Mar 16, 2023
donoghuc
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.